Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨(dashboard) Consent management #245

Merged
merged 1 commit into from
Dec 10, 2024
Merged

✨(dashboard) Consent management #245

merged 1 commit into from
Dec 10, 2024

Conversation

ssorin
Copy link
Collaborator

@ssorin ssorin commented Nov 29, 2024 •
edited
Loading

Purpose

Add a form that allows to validate consent of the delivery points that the user owns or delegates over.
It is possible to validate all delivery points at once or to do it by entity.
A page displays the entities with delivery points awaiting consent.

Add

  • add Consent management views and template
  • add JavaScript functionality to select/uncheck all checkboxes in consent forms
  • enhance the admin interface
  • add test
  • add migration to proxy_for symmetrical=False

@ssorin ssorin added feature needs review dashboard Item related to the Dashboard service labels Nov 29, 2024
@ssorin ssorin self-assigned this Nov 29, 2024
@ssorin ssorin requested a review from jmaupetit November 29, 2024 17:22
ssorin
ssorin commented Dec 2, 2024
View reviewed changes
src/dashboard/apps/consent/views.py Outdated Show resolved Hide resolved
src/dashboard/apps/consent/views.py Outdated Show resolved Hide resolved
src/dashboard/apps/consent/consent_management.py Outdated Show resolved Hide resolved
src/dashboard/apps/consent/consent_management.py Outdated Show resolved Hide resolved
src/dashboard/apps/consent/consent_management.py Outdated Show resolved Hide resolved
src/dashboard/apps/consent/consent_management.py Outdated Show resolved Hide resolved
src/dashboard/apps/consent/querysets.py Outdated Show resolved Hide resolved
src/dashboard/apps/consent/querysets.py Outdated Show resolved Hide resolved
src/dashboard/apps/consent/querysets.py Outdated Show resolved Hide resolved
src/dashboard/apps/consent/tests/test_querysets.py Outdated Show resolved Hide resolved
jmaupetit
jmaupetit reviewed Dec 2, 2024
View reviewed changes
Copy link
Member

@jmaupetit jmaupetit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I have to test it locally and make a second round.

src/dashboard/apps/consent/consent_management.py Outdated Show resolved Hide resolved
src/dashboard/apps/consent/permissions_utils.py Outdated Show resolved Hide resolved
src/dashboard/apps/consent/querysets.py Outdated Show resolved Hide resolved
@ssorin ssorin force-pushed the feature/dashboard/consent-form branch 3 times, most recently from 61f1355 to 5d58156 Compare December 3, 2024 12:49
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

Current benchmark

Type Name Request Count Failure Count Median Response Time Average Response Time Min Response Time Max Response Time Average Content Size Requests/s Failures/s 50% 66% 75% 80% 90% 95% 98% 99% 99.9% 99.99% 100% git timestamp version
GET /auth/whoami 37 0 470.0 602.9379155405375 8.33165099999178 2545.231692000016 160.0 1.2756705214532995 0.0 470 700 770 790 1700 2100 2500 2500 2500 2500 2500 4417fdc 2024-12-03 12:57:37.139422+00:00 0.15.0
POST /dynamique/session/ 30 0 780.0 927.8109691666638 14.568421000035414 3146.0655850000308 45.0 1.034327449827 0.0 780 970 1400 1700 2400 2800 3100 3100 3100 3100 3100 4417fdc 2024-12-03 12:57:37.139422+00:00 0.15.0
POST /dynamique/session/bulk 26 0 850.0 1026.5914153076951 37.65445800001999 3017.643220000025 411.0 0.8964171231833998 0.0 920 1200 1400 1800 2800 2800 3000 3000 3000 3000 3000 4417fdc 2024-12-03 12:57:37.139422+00:00 0.15.0
GET /dynamique/status/ 41 0 840.0 855.3562798536589 10.576822000018636 3293.686830000013 285.0 1.4135808480969 0.0 840 1100 1200 1300 1900 3000 3300 3300 3300 3300 3300 4417fdc 2024-12-03 12:57:37.139422+00:00 0.15.0
POST /dynamique/status/ 27 0 790.0 1008.1789057777733 17.446707999965838 3315.268586000002 45.0 0.9308947048443 0.0 790 970 1500 1600 2800 3000 3300 3300 3300 3300 3300 4417fdc 2024-12-03 12:57:37.139422+00:00 0.15.0
GET /dynamique/status/FRALLEGO002006P3 23 0 650.0 684.8210286521817 30.329802000039763 3212.8622729999847 283.0 0.7929843782006999 0.0 650 830 930 1100 1200 2400 3200 3200 3200 3200 3200 4417fdc 2024-12-03 12:57:37.139422+00:00 0.15.0
GET /dynamique/status/FRALLEGO002006P3/history 27 0 740.0 767.9631187037036 11.024037000026963 2815.060722999988 39824.11111111111 0.9308947048443 0.0 740 930 1200 1400 1900 1900 2800 2800 2800 2800 2800 4417fdc 2024-12-03 12:57:37.139422+00:00 0.15.0
POST /dynamique/status/bulk 23 0 690.0 794.9078205652203 17.230185000016718 2803.248744000029 411.0 0.7929843782006999 0.0 690 980 1200 1600 2100 2300 2800 2800 2800 2800 2800 4417fdc 2024-12-03 12:57:37.139422+00:00 0.15.0
POST /statique/ 37 2 790.0 845.5359862432442 21.88194799998655 2813.1655990000013 65.45945945945945 1.2756705214532995 0.0689551633217999 790 1000 1200 1500 1900 2700 2800 2800 2800 2800 2800 4417fdc 2024-12-03 12:57:37.139422+00:00 0.15.0
GET /statique/?limit=10 20 0 930.0 1041.7153127000004 20.69286200003262 3318.0378430000133 13826.45 0.689551633218 0.0 930 1400 1700 1800 2800 3300 3300 3300 3300 3300 3300 4417fdc 2024-12-03 12:57:37.139422+00:00 0.15.0
GET /statique/?limit=100 22 0 970.0 1227.8062753181769 137.75314399998706 3585.9715120000146 129006.40909090907 0.7585067965397999 0.0 1000 1200 1700 1700 3000 3300 3600 3600 3600 3600 3600 4417fdc 2024-12-03 12:57:37.139422+00:00 0.15.0
PUT /statique/FR073EP7QU5233 43 0 350.0 717.1512484418598 25.26902599998948 3214.424887000007 1371.0 1.4825360114186998 0.0 350 1000 1200 1400 1900 2000 3200 3200 3200 3200 3200 4417fdc 2024-12-03 12:57:37.139422+00:00 0.15.0
GET /statique/FRALLEGO002006P3 34 0 720.0 760.3655450882377 14.263401999983216 2045.3323969999813 1202.0 1.1722377764705998 0.0 730 960 1200 1500 1700 1700 2000 2000 2000 2000 2000 4417fdc 2024-12-03 12:57:37.139422+00:00 0.15.0
POST /statique/bulk 32 0 1200.0 1428.2701579062548 541.9533449999676 2839.9508040000114 1125.21875 1.1032826131487998 0.0 1400 1500 2000 2000 2600 2800 2800 2800 2800 2800 2800 4417fdc 2024-12-03 12:57:37.139422+00:00 0.15.0
Aggregated 422 2 770.0 889.6186433317547 8.33165099999178 3585.9715120000146 10367.27251184834 14.549539460899798 0.0689551633217999 780 1000 1300 1500 2000 2800 3000 3300 3600 3600 3600 4417fdc 2024-12-03 12:57:37.139422+00:00 0.15.0

Comparison with the latest previous benchmark

A lower (negative) value means the current version performs better than the previous one.

Type Name Request Count Failure Count Median Response Time Average Response Time Min Response Time Max Response Time Average Content Size Requests/s
GET /auth/whoami -412 0 429.0 412.2558754641515 5.305982006632348 996.2986129994538 0.0 -14.227179828781626
GET /statique/?limit=10 -385 0 590.0 618.06389171136 -0.8866199933663665 1548.7166850120389 -13777.0 -13.294587684577218
GET /statique/?limit=100 -398 0 530.0 574.8989641965047 -58.94253501116963 1209.440917014433 -128591.0 -13.743245568352476
Aggregated -1247 0 620.0 540.3882112128258 7.551153006659204 1485.4845270144208 -46690.79037267081 -43.05784732807812

@ssorin ssorin marked this pull request as ready for review December 3, 2024 14:06
@ssorin ssorin force-pushed the feature/dashboard/consent-form branch 2 times, most recently from 3cb418d to 97d69d4 Compare December 6, 2024 15:00
jmaupetit
jmaupetit reviewed Dec 10, 2024
View reviewed changes
Copy link
Member

@jmaupetit jmaupetit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🤩

I think we must think a bit more UX/UI in another PR.

src/dashboard/apps/consent/__init__.py Show resolved Hide resolved
src/dashboard/apps/consent/managers.py Outdated Show resolved Hide resolved
src/dashboard/apps/core/models.py Outdated Show resolved Hide resolved
src/dashboard/apps/auth/models.py Outdated Show resolved Hide resolved
src/dashboard/apps/auth/models.py Outdated Show resolved Hide resolved
src/dashboard/apps/auth/models.py Outdated Show resolved Hide resolved
@ssorin ssorin force-pushed the feature/dashboard/consent-form branch 2 times, most recently from 2c85e99 to 4ce0f5d Compare December 10, 2024 17:12
jmaupetit
jmaupetit approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@jmaupetit jmaupetit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ssorin
✨(dashboard) Consent management
fd64e6f 
- add Consent management views and template
- add JavaScript functionality to select/uncheck all checkboxes in consent forms
- enhance the admin interface
- add test
- add migration to proxy_for symmetrical=False
@ssorin ssorin force-pushed the feature/dashboard/consent-form branch from 4ce0f5d to fd64e6f Compare December 10, 2024 21:14
@ssorin ssorin merged commit ff333ad into main Dec 10, 2024
10 checks passed
@ssorin ssorin deleted the feature/dashboard/consent-form branch December 10, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmaupetit jmaupetit jmaupetit approved these changes

Assignees

@ssorin ssorin

Labels
dashboard Item related to the Dashboard service feature needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ssorin @jmaupetit